Adyen: Add support for Pan Only GooglePay #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradbroge
requested changes
Aug 19, 2024
| @@ -1,3 +1,4 @@ | |||
| require 'pry' | |||
| post[:additionalData]['paymentdatasource.tokenized'] = options[:wallet_type] ? 'false' : 'true' if selected_brand == 'googlepay' | ||
| end | ||
|
|
||
| return if options[:skip_mpi_data] == 'Y' || options[:wallet_type] |
There was a problem hiding this comment.
Is wallet_type a gsf, or where is it coming from? If so is there a chance that a customer would send this with a NetworkTokenizationCreditCard and we would skip mpiData in a case where we might not want to?
There was a problem hiding this comment.
wallet_type get's passed by us for non-tokenized GooglePays which would be a CreditCard in AM. That's why we want to skip it because they wouldn't have cryptogram or eci.
There was a problem hiding this comment.
Awesome! That is perfect, just making sure it couldn't be passed by mistake on regular CCs.
almalee24
force-pushed
the
adyen_google_pay_non_tokenized
branch
from
22d0a5e
to
a75bbe9
Compare
bradbroge
approved these changes
Aug 20, 2024
DustinHaefele
approved these changes
Aug 20, 2024
Remote 146 tests, 469 assertions, 12 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.7808% passed If it is a Pan Only GooglePay then pass 'paymentdatasource.type and selectedBrand as googlepay and paymentdatasource.tokenized as false
almalee24
force-pushed
the
adyen_google_pay_non_tokenized
branch
from
a75bbe9
to
1f4030f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote
146 tests, 469 assertions, 12 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.7808% passed
If it is a Pan Only GooglePay then pass 'paymentdatasource.type and selectedBrand as googlepay and paymentdatasource.tokenized as false