Ebanx: Add support for Stored Credentials #5223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almalee24
force-pushed
the
ebanx_stored_creds
branch
from
72eb60b
to
eb6b2f4
Compare
| @@ -50,6 +50,7 @@ def purchase(money, payment, options = {}) | |||
| add_address(post, options) | |||
| add_customer_responsible_person(post, payment, options) | |||
| add_additional_data(post, options) | |||
| add_stored_credentials(post, options) | |||
There was a problem hiding this comment.
This is possibly just me still learning stored credentials, but should this be added to authorize or captures as well? Or does this only work on a full purchase? Particularly for initial transactions.
There was a problem hiding this comment.
I forgot to add it in authorize but let be double check if we need it for capture
There was a problem hiding this comment.
I've added it to Authorize since this is only for ws/direct API which is just Purchase & Authorize
almalee24
force-pushed
the
ebanx_stored_creds
branch
from
eb6b2f4
to
be25155
Compare
DustinHaefele
approved these changes
Aug 21, 2024
Remote 39 tests, 95 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.8718% passed
almalee24
force-pushed
the
ebanx_stored_creds
branch
from
be25155
to
b789edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.