Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decidir: Update scrubbing cryptogram and token #5225

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

almalee24
Copy link

Update scrubbing cryptogram in Prod since they add / in prod from cryptogram and we only want to scrub
the token in token_card_data

@almalee24 almalee24 requested a review from a team August 21, 2024 17:27
@almalee24 almalee24 force-pushed the update_decidir_cryptogram_scrub branch from 47686fd to 1e32ebc Compare August 21, 2024 17:28
@@ -360,14 +360,4 @@ def test_transcript_scrubbing
assert_scrubbed(@credit_card.verification_value, transcript)
assert_scrubbed(@gateway_for_purchase.options[:api_key], transcript)
end

def test_transcript_scrubbing_network_token
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this since cryptogram in Sandbox doesn't return the '/' in front of cryptogram value

Copy link
Contributor

@bradbroge bradbroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Update scrubbing cryptogram in Prod since they add /
in prod from cryptogram and we only want to scrub
the token in token_card_data
@almalee24 almalee24 force-pushed the update_decidir_cryptogram_scrub branch from 1e32ebc to ef571f5 Compare August 21, 2024 18:27
@almalee24 almalee24 merged commit ef571f5 into master Aug 21, 2024
5 checks passed
@almalee24 almalee24 deleted the update_decidir_cryptogram_scrub branch August 21, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants