Plexo: remove Bin and Last4 fields from NetworkToken #5234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ------------------------------ For NT transactions we must pass the Bin and the last4 digits of the underlying PAN, otherwise we can't pass it currently we where passing those values based in the NT number instead of PAN ones, and due we don't have the underlying PAN, those lines are unnecesary. Remote Tests: ------------------------------ Finished in 44.017128 seconds. 32 tests, 65 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 100% passed Unit Tests: ------------------------------ Finished in 0.040727 seconds. 25 tests, 140 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Rubocop ------------------------------ 798 files, no offenses detected
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For NT transactions we must pass the Bin and the last4 digits of the underlying PAN, otherwise we can't pass it currently we where passing those values based in the NT number instead of PAN ones, and due we don't have the underlying PAN, those lines are unnecesary.
Remote Tests:
Finished in 44.017128 seconds.
32 tests, 65 assertions, 0 failures, 0 errors, 0 pendings, 3 omissions, 0 notifications 100% passed
Unit Tests:
Finished in 0.040727 seconds.
25 tests, 140 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Rubocop
798 files, no offenses detected