Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StripePI: Update Stored Credentials #5236

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

almalee24
Copy link

Update Stored Credentials to only send NTID if
stored_credential_transaction_type is
setup_off_session_unscheduled or setup_off_session_recurring.

Remote:
96 tests, 457 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

@almalee24 almalee24 requested a review from a team August 27, 2024 22:19
Copy link
Contributor

@sinourain sinourain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tried to move the code so I wouldn't have to delete the network_transaction_id option, but then I convinced myself that it's the best option we have, good job!

Update Stored Credentials to only send NTID if
stored_credential_transaction_type is
setup_off_session_unscheduled or setup_off_session_recurring.

Remote:
96 tests, 457 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@almalee24 almalee24 force-pushed the stripe_stored_credentials_update branch from bf30a71 to cdd8f62 Compare September 11, 2024 15:59
@almalee24 almalee24 merged commit cdd8f62 into master Sep 11, 2024
5 checks passed
@almalee24 almalee24 deleted the stripe_stored_credentials_update branch September 11, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants