Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe PI: Add challenge as valid value for request_three_d_secure #5238

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jcreiff
Copy link
Contributor

@jcreiff jcreiff commented Aug 28, 2024

Stripe changelog entry announcing the new field

CER-1717

LOCAL
6007 tests, 80257 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed;

RUBOCOP
Inspecting 801 files
801 files inspected, no offenses detected

UNIT
62 tests, 321 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

REMOTE
95 tests, 454 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed

@jcreiff jcreiff requested review from a team August 28, 2024 18:59
Copy link
Contributor

@DustinHaefele DustinHaefele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for linking the associated changelog and updating the tests! :shipit:

CER-1717

LOCAL
6007 tests, 80257 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

RUBOCOP
Inspecting 801 files
801 files inspected, no offenses detected

UNIT
62 tests, 321 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed

REMOTE
95 tests, 454 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
@jcreiff jcreiff force-pushed the stripe_pi_request_challenge branch from ed27bb6 to 166ca88 Compare August 29, 2024 19:40
@jcreiff jcreiff merged commit 166ca88 into master Aug 29, 2024
5 checks passed
@jcreiff jcreiff deleted the stripe_pi_request_challenge branch August 29, 2024 19:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants