SafeCharge: add card holder verification fields #5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreiff
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Looks good to me!
I was curious to see if sending the card_holder_verification field would change the response sent back from SafeCharge, and it does look like they add a CardHolderNameVerification object to the response. You could add an assertion to the remote test to show that it's present, but I will ✅ this either way
yunnydang
force-pushed
the
safecharge_add_card_holder_verification_fields
branch
from
b3601df
to
25410f8
Compare
yunnydang
force-pushed
the
safecharge_add_card_holder_verification_fields
branch
from
25410f8
to
d615d35
Compare
yunnydang
deleted the
safecharge_add_card_holder_verification_fields
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the optional middle_name and card_holder_verification fields
Local:
6017 tests, 80326 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Unit:
31 tests, 176 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
Remote:
35 tests, 93 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
94.2857% passed