Adds temperature compensation #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it looks like i didn't lint it. |
FoamyGuy
approved these changes
Sep 8, 2024
There was a problem hiding this comment.
This looks good to me. I do not have the hardware to test with.
I did have a look thru the datasheet and the implementation here seems consistent with it as far as I understand it.
Thanks for adding this functionality @purepani
|
Thanks! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 9, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.2.0 from 2.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#39 from purepani/add_temperature_compensation Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 6.1.2 from 6.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_HID#128 from dhalbert/usb-hid-keyboard Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#66 from timchinowsky/add_pioasm_i2c_codec Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to enable temperature compensation
Since this feature pretty much requires access to the offset properties, they should be added as well.
I didn't have time today, but might add them tomorrow.
Fixes #36