-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 833 support for v7 Softdevice (while not including new boards) #250
Merged
hathach
merged 22 commits into
adafruit:master
from
jpconstantineau:V7-SD-FROM-KBLADEWHT
Dec 22, 2021
Merged
add 833 support for v7 Softdevice (while not including new boards) #250
hathach
merged 22 commits into
adafruit:master
from
jpconstantineau:V7-SD-FROM-KBLADEWHT
Dec 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SD-FROM-KBLADEWHT
hathach
reviewed
Dec 20, 2021
hathach
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look great now, thank you for your PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the work of @kbladewht but removes the 3 new boards that prevented this work from being merged in.
This should also close #231
Did a rebase off of the head of the repo. Closed the previous PRs as they brought in unwanted commits. This one is in line with the original PR #231 but removes the additional boards.
It also does not change the config of the existing boards to use the new SD. This should come separate in another commit once this one is in.