Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembly attributes not written (or overwritten) using SDK 3.1.300 #343

Closed
joacar opened this issue May 25, 2020 · 3 comments
Closed

Assembly attributes not written (or overwritten) using SDK 3.1.300 #343

joacar opened this issue May 25, 2020 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@joacar
Copy link

joacar commented May 25, 2020

It works great if built with SDK < 3.1.300 but fails on 3.1.300.

Version(s)

2.2.0

To reproduce

There is a tag 2.1.3 and that value should be displayed at first run.

  1. Run included console app
  2. Change global.json to 3.1.300
  3. Run included console app

ConsoleApp2.zip

Expected behavior

See informational version 2.1.3 as calculated by MinVer

Actual behaviour

Default 1.0.0

Workarounds

Haven't find any. Tried to elaborate will target order but no luck.

Additional context

Only seen this in 3.1.300
@joacar joacar added the bug Something isn't working label May 25, 2020
@bording bording mentioned this issue May 25, 2020
Closed
@bording
Copy link
Collaborator

bording commented May 25, 2020

@joacar See #344 for more details and the fix.

@joacar
Copy link
Author

joacar commented May 26, 2020

@bording Great job with a quick fix!

@adamralph adamralph mentioned this issue May 26, 2020
Merged
@adamralph
Copy link
Owner

@joacar thanks for raising this and for the detailed repro! Since this was caused by a breaking change in SDK 3.1.300, I'm not treating this as a bug in MinVer, so I'm withdrawing this issue in favour of #347.

@adamralph adamralph added duplicate This issue or pull request already exists and removed bug Something isn't working labels May 26, 2020
@adamralph adamralph closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more BeforeTargets to MinVer target
3 participants
@joacar @adamralph @bording