Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more BeforeTargets to MinVer target #344

Closed
wants to merge 1 commit into from
Closed

Add more BeforeTargets to MinVer target #344

wants to merge 1 commit into from

Conversation

bording
Copy link
Collaborator

@bording bording commented May 25, 2020 •
edited
Loading

dotnet/sdk#10613 made a change to the GenerateAssemblyInfo target to fix a problem related to Source Link.

This change ensures that the MinVer target is called early enough to get the version values populated before GenerateAssemblyInfo writes them to disk in the generated AssemblyInfo.cs file.

Fixes #343

@bording bording mentioned this pull request May 25, 2020
Closed
@bording bording changed the title Add more BeforeTargets to MinVer targets Add more BeforeTargets to MinVer target May 25, 2020
@bording bording mentioned this pull request May 25, 2020
Closed
@adamralph
Copy link
Owner

Thanks @bording! I'm busy right now but I'll merge and release ASAP.

@adamralph adamralph mentioned this pull request May 26, 2020
Merged
@adamralph
Copy link
Owner

@bording thanks again for raising this. I cherry-picked the commit into #347.

@adamralph adamralph closed this May 26, 2020
@bording bording deleted the add-more-before-targets branch May 26, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assembly attributes not written (or overwritten) using SDK 3.1.300
2 participants
@bording @adamralph