Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order GenerateAssemblyInfo target before BeforeCompile #10613

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 7, 2020

Fixes #10614

@tmat
Copy link
Member Author

tmat commented Feb 7, 2020

@nguerrera PTAL

@tmat tmat merged commit e605483 into dotnet:master Feb 7, 2020
@tmat tmat deleted the GenerateAssemblyInfoOrdering branch February 7, 2020 21:48
tmat added a commit to tmat/sdk that referenced this pull request Feb 8, 2020
ghost pushed a commit that referenced this pull request Mar 30, 2020
…w2' (#11047)

* update to 3.1.2 runtime (#10699)

* Align runtime with v3.1.102

* Update stage0

* Update global.json

* Update dependencies from https://github.com/NuGet/NuGet.Client build 5.5.0.6473 (#10722)

- NuGet.Build.Tasks - 5.5.0-rtm.6473

* Update branding

* Update branding to preview

* Order GenerateAssemblyInfo target before BeforeCompile (#10613) (#10616)

* Update to nuget build used in cli/toolset

* Updating stage 0

* Updating ComputeFilesCopiedToPublishDir to work during design time builds

* Simplifying new test

* Update NuGet to 5.6.0.6489 (#10847)

* Update NuGet to 5.6.0.6489

* Update Version.Details.xml with new NuGet version info

* Update stage 0

Co-authored-by: William Li <wul@microsoft.com>

Co-authored-by: William Li <wul@microsoft.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomáš Matoušek <tmat@users.noreply.github.com>
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Co-authored-by: sfoslund <sfoslund@microsoft.com>
Co-authored-by: Luke Westendorf <lukewest@microsoft.com>
Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenerateAssemblyInfo is not ordered before BeforeCompile
3 participants