Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove postcss-nested #3418

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Remove postcss-nested #3418

merged 1 commit into from
Jan 4, 2024

Conversation

nstepien
Copy link
Contributor

@nstepien nstepien commented Jan 4, 2024

Some output diff:
image
image
image

  • Layers order is now at the top of the stylesheet, which I believe is actually the correct way to use layers.
  • We will now ship native CSS nesting

https://caniuse.com/css-nesting

@nstepien nstepien self-assigned this Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (421568e) 98.27% compared to head (ee665f0) 98.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3418      +/-   ##
==========================================
- Coverage   98.27%   98.26%   -0.01%     
==========================================
  Files          47       47              
  Lines        5097     5082      -15     
  Branches      727      726       -1     
==========================================
- Hits         5009     4994      -15     
  Misses         88       88              
Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/style/core.ts 100.00% <100.00%> (ø)

@nstepien nstepien marked this pull request as ready for review January 4, 2024 16:55
Copy link
Contributor

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nstepien nstepien merged commit 36080cc into main Jan 4, 2024
3 checks passed
@nstepien nstepien deleted the native-nest branch January 4, 2024 17:08
adityatoshniwal pushed a commit to pgadmin-org/react-data-grid that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants