Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to tanstack router #3600

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Migrate to tanstack router #3600

merged 2 commits into from
Sep 13, 2024

Conversation

@nstepien nstepien self-assigned this Sep 13, 2024

let rows: readonly Row[] | undefined;

function createRows(): Row[] {
Copy link
Contributor Author

@nstepien nstepien Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still blocks the browser while creating all the rows.

There are a few alternative:

Would be interesting to set up a web worker.

    const row = await scheduler.postTask(
      (): Row => ({
        id: `id_${i}`,
        avatar: faker.image.avatar(),
        email: faker.internet.email(),
        title: faker.person.prefix(),
        firstName: faker.person.firstName(),
        lastName: faker.person.lastName(),
        street: faker.location.street(),
        zipCode: faker.location.zipCode(),
        date: faker.date.past().toLocaleDateString(),
        bs: faker.company.buzzPhrase(),
        catchPhrase: faker.company.catchPhrase(),
        companyName: faker.company.name(),
        words: faker.lorem.words(),
        sentence: faker.lorem.sentence()
      })
    );

    rows.push(row);

@nstepien nstepien marked this pull request as ready for review September 13, 2024 13:49
Copy link
Contributor

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nstepien nstepien merged commit be8907a into main Sep 13, 2024
3 checks passed
@nstepien nstepien deleted the tanrouter branch September 13, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants