JabRef#8491 : Fix Check Style errors pt 2

addak · Feb 26, 2022 · 24f2aa3 · 24f2aa3
1 parent 98e71b9
commit 24f2aa3
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 13 deletions.
diff --git a/src/main/java/org/jabref/logic/xmp/DublinCoreExtractor.java b/src/main/java/org/jabref/logic/xmp/DublinCoreExtractor.java
@@ -419,7 +419,9 @@ private void fillTitle(String title) {
      *
      * @param coverage
      */
-    private void fillCoverage(String coverage) { dcSchema.setCoverage(coverage); }
+    private void fillCoverage(String coverage) {
+        dcSchema.setCoverage(coverage);
+    }
 
     /**
      * BibTex Field : language ; DC Field : dc:language
@@ -443,17 +445,19 @@ private void fillLanguages(String languages) {
 
     /**
      * BibTex : Rights (Custom Field); DC Field : dc:rights
+     *
      * @param rights
      */
-    private void fillRights(String rights){
+    private void fillRights(String rights) {
         dcSchema.addRights(null, rights.split(",")[0]);
     }
 
     /**
      * BibTex : Source (Custom Field); DC Field : Source
+     *
      * @param source
      */
-    private void fillSource(String source){
+    private void fillSource(String source) {
         dcSchema.setSource(source);
     }
 
@@ -513,8 +517,9 @@ public void fillDublinCoreSchema() {
                         break;
                     case MONTH:
                     case DAY:
-                        if (hasStandardYearField)
+                        if (hasStandardYearField) {
                             break;
+                        }
                     default:
                         this.fillCustomField(field.getKey(), field.getValue());
                 }

diff --git a/src/main/java/org/jabref/logic/xmp/XmpUtilReader.java b/src/main/java/org/jabref/logic/xmp/XmpUtilReader.java
@@ -10,14 +10,14 @@
 
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.LinkedFile;
+import org.jabref.model.schema.DublinCoreSchemaCustom;
 
 import org.apache.pdfbox.Loader;
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.pdmodel.PDDocumentCatalog;
 import org.apache.pdfbox.pdmodel.PDDocumentInformation;
 import org.apache.pdfbox.pdmodel.common.PDMetadata;
 import org.apache.xmpbox.XMPMetadata;
-import org.jabref.model.schema.DublinCoreSchemaCustom;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

diff --git a/src/main/java/org/jabref/logic/xmp/XmpUtilWriter.java b/src/main/java/org/jabref/logic/xmp/XmpUtilWriter.java
@@ -19,6 +19,7 @@
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.field.Field;
 import org.jabref.model.entry.field.StandardField;
+import org.jabref.model.schema.DublinCoreSchemaCustom;
 
 import org.apache.pdfbox.Loader;
 import org.apache.pdfbox.pdmodel.PDDocument;
@@ -28,7 +29,6 @@
 import org.apache.xmpbox.XMPMetadata;
 import org.apache.xmpbox.schema.DublinCoreSchema;
 import org.apache.xmpbox.xml.XmpSerializer;
-import org.jabref.model.schema.DublinCoreSchemaCustom;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

diff --git a/src/main/java/org/jabref/model/schema/DublinCoreSchemaCustom.java b/src/main/java/org/jabref/model/schema/DublinCoreSchemaCustom.java
@@ -1,5 +1,8 @@
 package org.jabref.model.schema;
 
+import java.util.Objects;
+import javax.xml.XMLConstants;
+
 import org.apache.commons.lang3.exception.ExceptionUtils;
 import org.apache.commons.lang3.reflect.FieldUtils;
 import org.apache.xmpbox.XMPMetadata;
@@ -11,9 +14,6 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import javax.xml.XMLConstants;
-import java.util.Objects;
-
 @StructuredType(preferedPrefix = "dc", namespace = "http://purl.org/dc/elements/1.1/")
 public class DublinCoreSchemaCustom extends DublinCoreSchema {
 

diff --git a/src/test/java/org/jabref/logic/xmp/XmpUtilWriterTest.java b/src/test/java/org/jabref/logic/xmp/XmpUtilWriterTest.java
@@ -20,7 +20,9 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
-import static org.jabref.logic.xmp.DublinCoreExtractor.*;
+import static org.jabref.logic.xmp.DublinCoreExtractor.DC_COVERAGE;
+import static org.jabref.logic.xmp.DublinCoreExtractor.DC_RIGHTS;
+import static org.jabref.logic.xmp.DublinCoreExtractor.DC_SOURCE;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
@@ -71,10 +73,10 @@ private void initBibEntries() {
         vapnik2000.setField(StandardField.AUTHOR, "Vladimir N. Vapnik");
         vapnik2000.setField(StandardField.DOI, "10.1007/978-1-4757-3264-1");
         vapnik2000.setField(StandardField.OWNER, "Ich");
-        vapnik2000.setField(StandardField.LANGUAGE,"English, Japanese");
-        vapnik2000.setDate(new Date(2314,11,1));
+        vapnik2000.setField(StandardField.LANGUAGE, "English, Japanese");
+        vapnik2000.setDate(new Date(2314, 11, 1));
 
-        vapnik2000.setField(new UnknownField(DC_COVERAGE),"coverageField");
+        vapnik2000.setField(new UnknownField(DC_COVERAGE), "coverageField");
         vapnik2000.setField(new UnknownField((DC_SOURCE)), "JabRef");
         vapnik2000.setField(new UnknownField(DC_RIGHTS), "Right To X");
     }