Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the .mc-modal-overlay & .mc-layer-overlay classes with .mc-overlay. #1059

Closed
1 of 3 tasks
tiloyi opened this issue Mar 13, 2022 · 0 comments · Fixed by #1188
Closed
1 of 3 tasks

Replace the .mc-modal-overlay & .mc-layer-overlay classes with .mc-overlay. #1059

tiloyi opened this issue Mar 13, 2022 · 0 comments · Fixed by #1188
Assignees
@tiloyi
Labels
BREAKING CHANGE This pull request create breaking change @next Anything related to the next major version
Milestone
Road to @mozaic-d...

Comments

@tiloyi
Copy link
Contributor

tiloyi commented Mar 13, 2022

🚀 Pattern enhancement proposal

What kind of enhancement are you proposing ?

  • On sketch file
  • On Documentation
  • On source code

Description

In the context of the arrival of the Overlay component, Replace the .mc-modal-overlay & .mc-layer-overlay classes with .mc-overlay.

Justification

Standardize the code
@tiloyi tiloyi added ✨ refactor A code change that neither fixes a bug nor adds a feature BREAKING CHANGE This pull request create breaking change @next Anything related to the next major version scope:component and removed ✨ refactor A code change that neither fixes a bug nor adds a feature labels Mar 13, 2022
@tiloyi tiloyi added this to the Road to @mozaic-ds v2 milestone Apr 26, 2022
@tiloyi tiloyi mentioned this issue Aug 19, 2022
Merged
4 tasks
@tiloyi tiloyi linked a pull request Aug 19, 2022 that will close this issue
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-overlay classes in favor of .mc-overlay #1188
Merged
4 tasks
@tiloyi tiloyi self-assigned this Aug 19, 2022
tiloyi added a commit that referenced this issue Sep 27, 2022
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
d515ab0 
…rlay classes in favor of .mc-overlay

Resolves #1059
tiloyi added a commit that referenced this issue Sep 27, 2022
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
1b6c905 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
@tiloyi tiloyi closed this as completed Sep 28, 2022
tiloyi added a commit that referenced this issue Dec 9, 2022
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
f54f14f 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
tiloyi added a commit that referenced this issue Dec 19, 2022
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
7a50177 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
tiloyi added a commit that referenced this issue Feb 3, 2023
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
c6c236f 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
tiloyi added a commit that referenced this issue Mar 21, 2023
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
a74c188 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
tiloyi added a commit that referenced this issue Mar 26, 2023
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
7a0e53e 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
tiloyi added a commit that referenced this issue May 9, 2023
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
ab10a3f 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
tiloyi added a commit that referenced this issue Jun 1, 2023
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
ca0799b 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
tiloyi added a commit that referenced this issue Jun 14, 2023
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
b0a8a34 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
tiloyi added a commit that referenced this issue Jun 15, 2023
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
821e532 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
tiloyi added a commit that referenced this issue Jun 21, 2023
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
dbc28e0 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
tiloyi added a commit that referenced this issue Dec 27, 2023
@tiloyi
feat(component/overlay): delete the .mc-layer-overlay & .mc-modal-ove…
0482ac5 
…rlay classes in favor of .mc-overlay (#1188)

Resolves #1059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiloyi tiloyi

Labels
BREAKING CHANGE This pull request create breaking change @next Anything related to the next major version
Projects
None yet
Milestone
Road to @mozaic-ds v2
2 participants
@tiloyi @caqueste