-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve a11y #48
Comments
Another thought on this: it might also be worth refactoring to place inputs outside of labels, and use |
Thanks for your hint @jacob-financeit! I'll have refresh my web a11y knowhow a little to implement this with confidence, so any hints and contributions are more than welcome 😊 |
Sorry, I was away for a bit. I think you can use Ember.guidFor() to make sure the label is associated with the right input |
Hi @jacob-financeit, thanks again for you input. I realized that most of our form components are already using the Using |
No, that's why I phrased it as a 'might'... it's more explicit, and more normative, which usually helps screenreaders (and has been good for i.e. specific versions of NVDA in the past), but it's not a totally unambiguous thing. (That's also why I haven't devoted work time to it yet, because there are bigger / easier wins in other areas of my current project.) For instance, one thing our QA pointed out is that validation messages are not read by i.e. VoiceOver. I am looking at making them ARIA live regions, so an update to a validation message will trigger it to be vocalized. |
Alright, that makes sense. Proper |
🎉 This issue has been resolved in version 6.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
We should include aria tags (like
aria-describedby
andaria-invalid
).The text was updated successfully, but these errors were encountered: