Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Mode Too Far! #267

Closed
sorens opened this issue Mar 10, 2021 · 3 comments
Closed

Dark Mode Too Far! #267

sorens opened this issue Mar 10, 2021 · 3 comments

Comments

@sorens
Copy link

sorens commented Mar 10, 2021

Using Source Code Pro with Visual Studio Code in Big Sur (just upgraded last night) results in Dark Text.

image

When I switch to another font, the text is readable again

image

Versions

Visual Studio Code

Version: 1.54.1
Commit: f30a9b73e8ffc278e71575118b6bf568f04587c8
Date: 2021-03-04T22:42:18.719Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Darwin x64 20.3.0

macOS: 11.2.3 (20D91)

Source Code Pro: https://github.com/adobe-fonts/source-code-pro/releases/tag/2.038R-ro%2F1.058R-it%2F1.018R-VAR

Referenced in issue: microsoft/vscode#100840

@frankrolf
Copy link
Member

This is caused by the internal SVG table, and has been fixed.
#250 has some more information.

You are referencing the latest release of the fonts in your link, but please make sure the font files you are using are actually those – it sounds very much like you are encountering the same issue as #250, which would indicate older fonts.

@sorens
Copy link
Author

sorens commented Mar 10, 2021

@frankrolf Interesting! So this morning, I downloaded 2.038 and installed it. I witnessed no change in behavior (i.e. text was still darkened). In that instance, I just installed the font over the existing one I had. After reading your note, I think maybe that upgrade path was flawed. This time, I removed my original Source Code Pro from Font Book.

Screen Shot 2021-03-10 at 2 24 42 PM

Then, I re-downloaded 2.038 and proceeded to install it back into Font Book. Having done that, I ran the same test I used this morning and now the text is visible!

Screen Shot 2021-03-10 at 2 28 24 PM

Thanks for helping me clarify my issue @frankrolf!

Closing, not a bug.

@sorens sorens closed this as completed Mar 10, 2021
@frankrolf
Copy link
Member

Great, likely a font caching issue.
Thanks for the follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants