Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CID of U+58FE from 14095 to 14094 #30

Closed
wants to merge 1 commit into from

Conversation

hfhchan
Copy link

@hfhchan hfhchan commented Apr 10, 2017

@jimmymasaru
Copy link

OpenType features also need changing, like substitute \14095 by \14094; in features.OTC.SC as well as other files.

@kenlunde kenlunde self-assigned this Apr 10, 2017
@kenlunde
Copy link
Contributor

kenlunde commented Apr 10, 2017

The way that the fonts are built, in terms of the inter-twined nature of such changes (a CMap resource change will trigger a change in some OpenType features, in particular the 'locl' GSUB feature if the mapping change is for an ideograph), makes it impossible to accept such pull requests. The language-specific lookups for 'locl' GSUB features are built using a tool that uses the CMap files to determine the substitutions. In other words, when a CMap change is made, this will trigger the rebuilding of the 'locl' GSUB feature. This cannot happen via a pull request. Any further pull requests like this will necessarily to be rejected for the same reason.

@kenlunde kenlunde closed this Apr 10, 2017
@hfhchan hfhchan deleted the patch-1 branch April 11, 2017 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants