Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trailing space in LICENSE.md line 65 #116

Open
tspiteri opened this issue Jan 27, 2023 · 3 comments
Open

trailing space in LICENSE.md line 65 #116

tspiteri opened this issue Jan 27, 2023 · 3 comments
Labels
addressed in source files completed in dev versions, but not yet released as fonts

Comments

@tspiteri
Copy link

Line 65 of the license file ending in "can be bundled, embedded, " has a trailing space. (I'm only bringing this nit up as I had to update this to appease format checkers in another project.)

Also, is there a reason why source-serif-4.005_Desktop.zip includes the license file but source-serif-4.005_WOFF.zip and source-serif-4.005_WOFF2.zip do not?

@frankrolf
Copy link
Member

Thanks for the report, I have to make a new release soon, and will include the license in all downloadable packages.

There is no reason for the license file missing in some of the downloads – it is the first time I package the license alongside the fonts (beyond having it in the release branch), this happens automatically upon building the fonts. The web font conversion simply does not copy over the license file to the respective folders.

(Why so many copies of the same file, if the OFL is linked within the fonts’ metadata? @mbutterick ?)
See also #107

@tspiteri
Copy link
Author

Why so many copies of the same file, if the OFL is linked within the fonts’ metadata?

Personally I'm fine with it just in source-serif-4.005R.zip and I don't have a preference either way in the _Desktop, _WOFF and _WOFF2 zips; I just found it inconsistent that _Desktop had it while _WOFF and _WOFF2 didn't.

frankrolf added a commit that referenced this issue Aug 23, 2023
@frankrolf frankrolf added the addressed in source files completed in dev versions, but not yet released as fonts label Aug 23, 2023
frankrolf added a commit that referenced this issue Aug 23, 2023
@frankrolf
Copy link
Member

The LICENSE.md has been updated in both development and release branches, and will therefore make it into the next build of Source Serif (no timeline yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addressed in source files completed in dev versions, but not yet released as fonts
Projects
None yet
Development

No branches or pull requests

2 participants