-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browser support tables #149
Add browser support tables #149
Conversation
Went with this style of comment @rhauck do you have the bandwidth to look at this? |
Also, we might want to centralize the browser support data rather than have it in each page so i can be used elsewhere on this site (like maybe as way to rebuild the enable page?) |
…he _data directory
Made the suggested updates. Browser logos are now separate svg files. The support data for shapes is also now in _data/browser_support.yml. |
…ables * upstream/master: Update README to reflect SASS build changes. remove unnecessary changes more feedback More fb from Bear Incorporate Bear && Rebecca fb Incorporate Bear && Rebecca fb
Because the images changed to be different files, they were no longer scaling the same, which caused each cell to be as wide as its text. I've changed the CSS to explicitly size the table cells given the number of columns generated. |
Looks good now on both phones now. Do you want to add this to the rest of the pages in this PR or merge this one and do the other pages separately? |
Merging this one and logged another issue for the others. |
Create a template mechanism for adding browser support tables, and add an initial table for the Shapes page. Part of the fixup work for bug #84.