Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mediaqueries support #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

csaunier
Copy link

@csaunier csaunier commented Apr 7, 2015

Hello,

In case of a personnal project, i had to use some shapes in mediaqueries but the polyfill throw an error and it appear it was not handled. It's also #10 issue.

So here it is :)

I've wrote a demo file : demos/mediaQueries-demo.html

@lmclister
Copy link
Member

@csaunier thank you for submitting this PR. Our contributor's license agreement system seems to have run a foul, so we will see if we can get it back up.

From briefly glancing at the PR, it looks like parts of it have come from other projects, which may make it difficult for us to accommodate it. Could you possible add a list of other other projects where code for this PR came from?

@csaunier
Copy link
Author

@lmclister indeed, i use some parts of only one another projet, Repond.js (https://github.com/scottjehl/Respond).

More specifically, i use 4 of his regexp (one that strip comment, one that split on @media, two to get minwidth and maxwidth), and his method that return the value of 1em in pixels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants