-
Notifications
You must be signed in to change notification settings - Fork 7.6k
User is able to create file/folders using relative path #13099
Comments
Do you want to take a look at this? |
@Simon66 Thanks for bringing it up. I can take a look into this later this week. If you want to pick it up before that , feel free to pick it up. |
@Simon66 is a student currently helping us (the Mozilla Foundation) run through a bug list for https://thimble.mozilla.org, which relies on brackets for its code editor part (it's on 1.4 at the moment but we're uplifting to 1.8), finding and fixing issues that are good first bugs for first time contributors. In this particular case, unless simon wants to dive very deep, I'd recommend having someone more knowledgeable w.r.t. the Brackets codebase look at this particular issue =) |
I think it's fine if he wants to try it. @Simon66 I'd suggest beginning with converting your STR above to a failing test case or two in https://github.com/tallandroid/brackets/blob/master/test/spec/ProjectModel-test.js, and once you can get your tests to fail, move on to a fix. |
Hi @humphd |
@Simon66 |
just wanted to update my progress on this bug. My main development unit died last week and I'm waiting for it to be repaired (I should've backed up my data haha). I should be getting it back today. I'll continue working on it as soon as I get my computer back :) Also, thanks @zaggino for letting me know where I can put my test cases 👍 |
@Simon66 thank you for the update! |
@Simon66 that's the nice thing about github forks: remember to push to your repo often, even if your code is "not ready for a PR" yet - you can't lose work that way, even if your computer catches fire =) (although hopefully of course they were able to fix your machine with all the data intact) |
Hi, I agree the list should be same for every OS as generally you don't want someone to push an invalid file to a project which other developer on different OS can't use. |
Prerequisites
Debug -> Reload Without Extensions
?Description
This bug was first found by @Pomax(mozilla#434) and then fixed by @tallandroid (#11862).
"It's possible to right-click in the file tree and create a file (or folder) name it
../something
, and the path isn't resolved, but rather the .. and / characters are treated as literals to be used in the filename itself." - @humphd(#11609)It looks like this bug wasn't fully fixed. I'm using the latest version of Brackets and I'm still able to reproduce it.
Steps to Reproduce
../../file1
)Expected behavior: An error message should show complaining about the relative path.
Actual behavior: File is renamed/created without an error message.
Versions
OS: macOS sierra 11.2.3
Brackets Version: 1.8 build 1.8.0-17108
The text was updated successfully, but these errors were encountered: