Fix #13099: Disallow user to create files/folder using relative path

[sdalmeida]

This is a Work In Progress PR referring to original issue #13099
Before this PR can be landed, it would be nice to know which chars are actually invalid.

These are the chars that I'm invalidating:

• \?
• \\
• \*
• \.{2,} <-- .. or more should not be allowed, but allow .
• \.$ <-- allow a file to have . but not end with .
• \/
• \|
• \>
• \<

I also have to add a unit test for this case.
Let me know if there are any chars that need to be added/removed.

[swmitra]

@Simon66 I still have the same confusion regarding invalid character handling code. Part of the reason is the way file names get validated by the OS, it's quite different in case of windows and osx. Not sure whether we can have a common regex validator as that would limit the file naming capability in either of the platform.

[swmitra]

What we can think about is, predominantly the projects being worked upon are web projects in Brackets. Eventually these files will be served and loaded in browser shells. What kind of restrictions do we have in the file names while serving them over network. Just thinking loud, may be not valid in this context.

[sdalmeida]

Another confusion of mine is why are these filenames considered "bad"

Why is com a valid filename and com1 not?
Also, I don't see why any of these file names are labelled as invalid.
Any ideas @tallandroid?

[sdalmeida]

@swmitra I think that no matter where this code lives (MacOS, Windows, Linux), those chars should be invalid. I'm not too sure why we should allow < or > on a linux env but not on Windows (Even though that char should be invalid on both OS.
But then again, which chars are invalid and which should not be.

[sdalmeida]

I've changed the function isValidFilename to disallow any file name that contains folder structure (like tmp\file.log) and I created a new function to check if full pathname is valid. I've also added some test cases.

[humphd]

This got left in by accident, please remove.

[sdalmeida]

@humphd Done 👍

[sdalmeida]

Hi @swmitra
I want to follow up on the status of this PR. I see that the code was approved but the PR is still open. There are many forked projects that might benefit from this bug fix 👍
Thanks :)

[nethip]

Thanks for your contributions @Simon66 .