-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Renaming twice a file in the working set shows wrong name #1971
Comments
Hi, I've pushed a possible solution, but I've found some other issues that I'd like to discuss. This error happens when the file of a document gets updated twice inside However, this only happens with documents opened in the current session for which the file entry in It may be worth looking into it deeper to consolidate both cases. |
Assigned to @gruehle |
@gruehle Thanks for your comments in #1975. Now that I've been looking more closely at this. This is what I've found:
It seems like we should have 3 ways to solve it, then:
I've already checked and all 3 solutions seem valid. What do you think? Which option feels better for a fix? To me, 2 and 3 are more consistent as we consolidate the behavior for documents in the workingSet one way or another, but maybe I'm still missing something here... |
@jbalsas I agree that options 2 and 3 are both better than option 1. Eventually this will all change when we get file watchers and have proper model objects that represent a file. In the meantime, it seems like option 2 is the simplest to implement and enforce. Thanks for investigating! |
Definitely some interesting philosophical questions here, for down the road... Glenn and I talked about this for a bit today. I've left a long comment in https://trello.com/card/8-file-directory-watching/4f90a6d98f77505d7940ce88/292 with notes. |
Make sure file entries in working set are different (#1971)
Confirmed fixed. Closing. Thanks @jbalsas for the fix! |
If you rename a file that is on the working set twice, Brackets seems to be updating the name twice
This may be related to #1870
Steps to reproduce
foo.bot
foo.b
foo.bar
Results:
foo.barar
, even if we close and open again the file.foo.barar
from the working set :)Expected:
The file in the working set should show
foo.bar
The text was updated successfully, but these errors were encountered: