Confirm Folder Deletion

[iangcarroll]

This would be extremely helpful so I don't delete my whole CSS folder, as I almost just did. phew

[peterflynn]

Reviewed. We should prompt to confirm folder deletion but not file deletion (like Sublime does).

Also fyi @snapapps, the folder would not be gone forever. Like other editors, our delete commands just move to trash / recycle bin. (If anyone has ideas for making this more clear in the UI, let us know!)

[WebsiteDeveloper]

I think changing if from "Delete" to something like "Move to trash" would be more clear.

[peterflynn]

@WebsiteDeveloper We'd need OS-specific strings in that case, but it seems reasonable to me...

[sathyamoorthi]

Just noticed. This is unfair. Anybody working on this?

[swapnilgt]

@peterflynn , @sathyamoorthi : Hi. I am new to this project and github. I would like to work on this. Where to find the required code for modification? Already checked out the code and set up for dev.

[discoursed]

@swapnilgt @peterflynn

[TomMalbran]

@swapnilgt The file delete handler is on src/document/DocumentCommandsHandlers.js at line 1135.

[swapnilgt]

@peterflynn any particular reason for not including the confirmation dialog for file deletion?

[peterflynn]

@swapnilgt Other editors like Sublime don't confirm for single files. Because the files are just moved to the trash, it's an easily undoable operation. Modern OSes are moving away from confirmation dialogs too (albeit for folders also).