This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Allow CSS Code Hints in PHP #11751
Merged
Allow CSS Code Hints in PHP #11751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {{editor:{CodeMirror}, pos:{ch:{string}, line:{number}}, token:{object}}} ctx | ||
| * @return {{tokenize:function, state:string, stateArg:string, context:Object}} | ||
| */ | ||
| function _getState(ctx) { |
There was a problem hiding this comment.
Can you rename it like _getTokenState or _getLocalState? _getState seems too common to me.
Can you add an assert for ctx?
There was a problem hiding this comment.
getContextState makes more sense here.
|
Hi guys, As we will be releasing 1.5 by Thursday, this change has to be pulled in by Tuesday or we could push this to 1.6. |
|
@abose Cool! Will push the changes in a while. |
sprintr
force-pushed
the
css-code-hints-php
branch
from
e67e1e3
to
cb4a065
Compare
sprintr
force-pushed
the
css-code-hints-php
branch
from
cb4a065
to
439d185
Compare
|
Thanks @sprintr . |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow CSS Code Hints in style tags for PHP files. Fixes #11629
CC: @abose