This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Issue #11261: keep the search bar open #14141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…result of clicking in the main editor. This is done by commenting out the code in line 256. The search bar will also close when the ESC key is pressed while the main editor has focus
…/automatically close * Add a close icon to the search bar (for completeness) * Fix escape key for in-editor searches * Remember last search phrase if no selection for in-editor searches
… until I can confirm with a Quebecois at work
ficristo
pushed a commit
to quadre-code/quadre
that referenced
this pull request
Dec 26, 2018
* It fixes issue adobe#11261 by preventing the search bar from closing as a result of clicking in the main editor. This is done by commenting out the code in line 256. The search bar will also close when the ESC key is pressed while the main editor has focus * Commented out unnecessary code around line 256 * [issue#11261] * Added in a menu option to allow find bar to stay open/automatically close * Add a close icon to the search bar (for completeness) * Fix escape key for in-editor searches * Remember last search phrase if no selection for in-editor searches * [issue#11261] Code clean up of initial mistakes of the previous commit * [issue#11261] Strange issue with spacing in src/nls/fr/strings.js... * [issue#11261] Strange issue with spacing in src/nls/fr/strings.js... * [issue#11261] Further merge conflict resolution and clean up * [issue#11261] Fix to branch and to testing * [issue#11261] Fixes for incorrect regexp processing * [issue#11261] Why does JSLint keep changing its own file * [issue#11261] Not sure about the french one, let's exclude it for now until I can confirm with a Quebecois at work * [issue#11261] Test left test file with change... * [issue adobe#11261] Minor fixes as per conversation of pull request * [Issue adobe#11261] Fixes mainly to the regular expression side of things * [Issue adobe#11261] Revert accidental change in JSLint * [issue adobe#11261] Remove loosy TODO and wording consistency change * [Issue adobe#11261] Remove Find Next on 'Find' option (we already have Find Next) * [Issue adobe#11261] (Retry the Travis CI build) * Totally forgot to actually save the merge conflict resolution. Here it is. * Merged master incorrectly - fix bad merge * Fix test Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
ficristo
pushed a commit
to quadre-code/quadre
that referenced
this pull request
Dec 26, 2018
* It fixes issue adobe#11261 by preventing the search bar from closing as a result of clicking in the main editor. This is done by commenting out the code in line 256. The search bar will also close when the ESC key is pressed while the main editor has focus * Commented out unnecessary code around line 256 * [issue#11261] * Added in a menu option to allow find bar to stay open/automatically close * Add a close icon to the search bar (for completeness) * Fix escape key for in-editor searches * Remember last search phrase if no selection for in-editor searches * [issue#11261] Code clean up of initial mistakes of the previous commit * [issue#11261] Strange issue with spacing in src/nls/fr/strings.js... * [issue#11261] Strange issue with spacing in src/nls/fr/strings.js... * [issue#11261] Further merge conflict resolution and clean up * [issue#11261] Fix to branch and to testing * [issue#11261] Fixes for incorrect regexp processing * [issue#11261] Why does JSLint keep changing its own file * [issue#11261] Not sure about the french one, let's exclude it for now until I can confirm with a Quebecois at work * [issue#11261] Test left test file with change... * [issue adobe#11261] Minor fixes as per conversation of pull request * [Issue adobe#11261] Fixes mainly to the regular expression side of things * [Issue adobe#11261] Revert accidental change in JSLint * [issue adobe#11261] Remove loosy TODO and wording consistency change * [Issue adobe#11261] Remove Find Next on 'Find' option (we already have Find Next) * [Issue adobe#11261] (Retry the Travis CI build) * Totally forgot to actually save the merge conflict resolution. Here it is. * Merged master incorrectly - fix bad merge * Fix test Signed-off-by: petetnt <pete.a.nykanen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11996
This PR adds additional test fix which seems to have occurred during merge/rebase