Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Norwegian Bokmål translation for build 100 #1448

Merged
merged 9 commits into from
Sep 7, 2012
Merged

Norwegian Bokmål translation for build 100 #1448

merged 9 commits into from
Sep 7, 2012

Conversation

thomasandersen
Copy link
Contributor

No description provided.

@ghost ghost assigned jasonsanjose Aug 27, 2012
@jasonsanjose
Copy link
Member

Reviewing. Please use lowercase for the no-NB folder name. See my comment in #1447. The "Switch Language" dialog will be fixed to pickup lowercase locales only.

@jasonsanjose jasonsanjose mentioned this pull request Aug 27, 2012
Merged
@thomasandersen
Copy link
Contributor Author

The latest commits fixes the letter case issue and syncs with current root/strings.js

jasonsanjose
jasonsanjose reviewed Sep 5, 2012
View reviewed changes
src/nls/no-nb/strings.js
"CMD_FIND" : "Finn",
"CMD_FIND_IN_FILES" : "Finn i filer",
"CMD_FIND_NEXT" : "Finn neste",
"CMD_FIND_PREVIOUS" : "Finn forige",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Translate tells me that there are 2 r's in forrige.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Translate is correct on this one

@jasonsanjose
Copy link
Member

Just 2 comments after running the translation through Google Translate. Normally for official translations we would have our localization team do a full Linguistic UI review. I'm trying to find out if we can skip that process for contributions at this point.

Also, there was a recent change in nls/root/strings.js that replaces Brackets with {APP_NAME}. You'll want to update your translation to match.

@jasonsanjose
Copy link
Member

Looks good. Merging.

jasonsanjose added a commit that referenced this pull request Sep 7, 2012
@jasonsanjose
Merge pull request #1448 from thomasandersen/no-NB-translation
7a2bc98 
Norwegian Bokmål translation for build 100
@jasonsanjose jasonsanjose merged commit 7a2bc98 into adobe:master Sep 7, 2012
@core-ai-bot core-ai-bot mentioned this pull request Aug 29, 2021
Open
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jasonsanjose jasonsanjose

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasandersen @jasonsanjose