Fix for #3773: Show Indexing Max Files Exceeded Error Dialog once

[dschaffe]

fixes issue #3773. minor fix to only show dialog "Error Indexing Files" "The maximum number of files have been indexed. Actions that look up files in the index may function incorrectly." The problem is if your current project has > 10k files you see this error every time you save an edit and dirty the cache. The fix is to show to error the first infraction and use console.log subsequent times.

[peterflynn]

Nit: add @type {boolean} annotation

[peterflynn]

It seems like _maxFileDialogDisplayed should get reset whenever a new project is loaded. If you split the "projectOpen projectFilesChange" listener at bottom in two then you can do it there on "projectOpen".

[peterflynn]

@dschaffe Done reviewing -- looks pretty good, just a few small comments.

Also, before we can merge this you'll need to sign the Brackets contributor agreement.

[dschaffe]

peterflynn: Thanks for reviewing the pull request. I signed the Brackets Contributor agreement and updated branch with your suggestions.

• split "projectOpen projectFilesChange", reset _maxFileDialogDisplayed on "projectOpen", tested this by triggering max files indexing, add new file to project = verify warning to console, open new project = verify dialog appears
• changed to !maxFileDialogDisplayed
• added annotation @type {boolean}

[peterflynn]

Looks good -- thanks @dschaffe! Merging.

[chriscantu]

I have several projects where I am leveraging 'bower.io' to manage my web dependencies and run into the limit frequently. Additionally, I do nodejs projects with the node_modules directory full of dependencies. I run into the limit constantly. It makes Brackets Quick Open feature unusable.

Would it be possible to ignore certain directories like app/bower_components and node_modules or give us the option to ignore them?

[peterflynn]

I suspect the right answer is to be smart about filtering out massive trees of third-party dependencies, a la this user story: https://trello.com/c/LgdleOVx/695-exclude-ignore-binary-files-libraries-or-subfolders-from-find-all-other-searches. We probably don't want to actually index 10k+ files (that's the sort of thing that contributes to IDE-like slow startup times & slow project loads, which we'd really like to avoid).

[unyo]

agreed, something should be done to limit the number of files being indexed. right now, since brackets starts up in my home directory (with a godawful number of .hidden directories), it'll freeze up almost every time to the point where i have to force kill brackets.

[peterflynn]

@unyo See https://github.com/adobe/brackets/wiki/Large-Projects