-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lots of minor coding issues. #1
Comments
@BlessJah thanks! I've implemented most of the things you've suggested (probably not every case of all issues you brought up, but I'll do that soon). Glad you like it :) |
@adtac In the install script, on line 144, you are checking for npm instead of pip, in the pip_verify function. Figured I'd let you know here as it's a very small issue. Cheers! |
@mckennajones argh, thanks! I just copy pasted the npm one with some changes :P I'll fix it right away 👍 |
Nice script, I find some of the ideas are pretty clever. Consider running it through shellcheck, lot of low hanging fruits in there.
Issues:
For portability reasons (I don't mean BSD and others, there are linux distros in the wild not having bash under /bin/bash):
Every day is a good day to learn something new. The variable is not used anyway.
Avoid variable leaking (example below).
Always quote variables to avoid splitting.
Variables shouldn't be used as
printf
formatting stringThere is no reason to use single square brackets test. In bash always use double. Also quotes.
Reading from
$1
and$2
and shifting is cleaner than double-shift.Awk is magic; quotes.
Backticks are evil, use
$()
. Also putting--utc
near everydate
in script may be a good idea (yeah, yeah, I know it's%s
).The text was updated successfully, but these errors were encountered: