This repository has been archived by the owner on May 21, 2024. It is now read-only.
garage-push: Always push the ostree ref. #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was disabled long ago, apparently under the assumption that garage-sign would push the ref. That isn't how it works. No one really seems to miss the refs, but they make operating on the ostree repos easier if they are there. Signed-off-by: Patrick Vacek <patrickvacek@gmail.com>
pattivacek
requested review from
simao,
lbonn,
eu-siemann,
mike-sul,
xcheng-here and
kbushgit
Codecov Report
@@ Coverage Diff @@
## master #1575 +/- ##
==========================================
+ Coverage 82.19% 82.26% +0.07%
==========================================
Files 189 189
Lines 11860 11854 -6
==========================================
+ Hits 9748 9752 +4
+ Misses 2112 2102 -10
Continue to review full report at Codecov.
|
lbonn
approved these changes
Feb 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was disabled long ago, apparently under the assumption that garage-sign would push the ref. That isn't how it works. No one really seems to miss the refs, but they make operating on the ostree repos easier if they are there.