Skip to content

GovernorCompatibilityBravo may trim proposal calldata

High severity GitHub Reviewed Published Apr 13, 2023 in OpenZeppelin/openzeppelin-contracts • Updated Apr 27, 2023

Package

npm @openzeppelin/contracts (npm)

Affected versions

>= 4.3.0, < 4.8.3

Patched versions

4.8.3
npm @openzeppelin/contracts-upgradeable (npm)
>= 4.3.0, < 4.8.3
4.8.3

Description

Impact

The proposal creation entrypoint (propose) in GovernorCompatibilityBravo allows the creation of proposals with a signatures array shorter than the calldatas array. This causes the additional elements of the latter to be ignored, and if the proposal succeeds the corresponding actions would eventually execute without any calldata. The ProposalCreated event correctly represents what will eventually execute, but the proposal parameters as queried through getActions appear to respect the original intended calldata.

Patches

This issue has been patched in v4.8.3.

Workarounds

Ensure that all proposals that pass through governance have equal length signatures and calldatas parameters.

References

@frangio frangio published to OpenZeppelin/openzeppelin-contracts Apr 13, 2023
Published by the National Vulnerability Database Apr 16, 2023
Published to the GitHub Advisory Database Apr 20, 2023
Reviewed Apr 20, 2023
Last updated Apr 27, 2023

Severity

High

CVSS overall score

This score calculates overall vulnerability severity from 0 to 10 and is based on the Common Vulnerability Scoring System (CVSS).
/ 10

CVSS v3 base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
Low
User interaction
None
Scope
Unchanged
Confidentiality
High
Integrity
High
Availability
High

CVSS v3 base metrics

Attack vector: More severe the more the remote (logically and physically) an attacker can be in order to exploit the vulnerability.
Attack complexity: More severe for the least complex attacks.
Privileges required: More severe if no privileges are required.
User interaction: More severe when no user interaction is required.
Scope: More severe when a scope change occurs, e.g. one vulnerable component impacts resources in components beyond its security scope.
Confidentiality: More severe when loss of data confidentiality is highest, measuring the level of data access available to an unauthorized user.
Integrity: More severe when loss of data integrity is the highest, measuring the consequence of data modification possible by an unauthorized user.
Availability: More severe when the loss of impacted component availability is highest.
CVSS:3.1/AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H

EPSS score

0.129%
(48th percentile)

Weaknesses

CVE ID

CVE-2023-30542

GHSA ID

GHSA-93hq-5wgc-jc82

Source code

Loading Checking history
See something to contribute? Suggest improvements for this vulnerability.