Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video links don't work with custom network #331

Closed
vania-pooh opened this issue Jan 11, 2018 · 3 comments
Closed

Video links don't work with custom network #331

vania-pooh opened this issue Jan 11, 2018 · 3 comments
Labels
Milestone

Comments

@vania-pooh
Copy link
Member

browser hostname does not seems to appear in video recorder container.

@vania-pooh vania-pooh added the bug label Jan 11, 2018
@vania-pooh vania-pooh added this to the 1.4.4 milestone Jan 11, 2018
@vania-pooh
Copy link
Member Author

For custom networks should use --network-alias flag:

$ docker run -it --rm --network-alias one --network testnet alpine:3.5 sh

In that case in any container from network testnet we can do:

$ ping -c 1 one

This alias should be generated and passed to video container as environment variable.

@vania-pooh
Copy link
Member Author

Found even better solution - can just use container name instead of links. It works via DNS.

aandryashin added a commit that referenced this issue Jan 20, 2018
Correctly working video recording in custom networks (fixes #331)
@vania-pooh
Copy link
Member Author

Fixed. In order to work you need to repull aerokube/video-recorder:latest (did changes in entrypoint there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant