Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort handler #598

Closed
potapovDim opened this issue Nov 2, 2018 · 3 comments · Fixed by #629
Closed

Abort handler #598

potapovDim opened this issue Nov 2, 2018 · 3 comments · Fixed by #629
Labels
bug
Milestone
1.8.4

Comments

@potapovDim
Copy link

Env
Windows 10 Pro. Version 1809
RAM 32 gb
Proc Intel (R) Xeon(R) cpu E5-2686 v4 2.30GHz

Selenoid: selenoid_windows_amd64.exe
Git Revision: 1.7.2
UTC Build Time: 2018-08-11_08:39:59AM

browsers 18 chrome 70 v, chromedriver 2.43

screen shot 2018-11-02 at 11 23 06 am
@vania-pooh vania-pooh added the bug label Nov 2, 2018
@vania-pooh vania-pooh added this to the 1.8.2 milestone Nov 2, 2018
@vania-pooh
Copy link
Member

@potapovDim shit. :) Will fix in next release.

@vania-pooh vania-pooh modified the milestones: 1.8.2, 1.8.3 Nov 12, 2018
@vania-pooh vania-pooh modified the milestones: 1.8.3, 1.8.4 Dec 14, 2018
@vania-pooh
Copy link
Member

Now reproducing on Linux too (at least in 1.8.1).

2018/12/14 15:48:21 httputil: ReverseProxy read error during body copy: unexpected EOF
panic: net/http: abort Handler

goroutine 78808798 [running]:
net/http/httputil.(*ReverseProxy).ServeHTTP(0xc0055d8280, 0x821b60, 0xc0051ac620, 0xc00158f700)
        /home/travis/.gimme/versions/go1.11.1.linux.amd64/src/net/http/httputil/reverseproxy.go:284 +0x1058
main.proxy.func1(0xc00298ed20, 0x821b60, 0xc0051ac620, 0xc00158f700)
        /home/travis/gopath/src/github.com/aerokube/selenoid/selenoid.go:445 +0xfb
created by main.proxy
        /home/travis/gopath/src/github.com/aerokube/selenoid/selenoid.go:403 +0x7a

@vania-pooh
Copy link
Member

Related to golang/go@eab57b2.

vania-pooh added a commit to vania-pooh/selenoid that referenced this issue Dec 18, 2018
@vania-pooh
Catching and logging potential panics (e.g. abortHandler) in proxy mo…
9e94692 
…de (fixes aerokube#598)
@vania-pooh vania-pooh mentioned this issue Dec 18, 2018
Merged
vania-pooh added a commit to vania-pooh/selenoid that referenced this issue Dec 18, 2018
@vania-pooh
Catching and logging potential panics (e.g. abortHandler) in proxy mo…
be3e451 
…de (fixes aerokube#598)
vania-pooh added a commit to vania-pooh/selenoid that referenced this issue Dec 18, 2018
@vania-pooh
Catching and logging potential panics (e.g. abortHandler) in proxy mo…
9fb8084 
…de (fixes aerokube#598)
vania-pooh added a commit to vania-pooh/selenoid that referenced this issue Dec 21, 2018
@vania-pooh
Correctly processing proxy request to avoid abortHandler panic (fixes a…
088f234 
…erokube#598)
vania-pooh added a commit to vania-pooh/selenoid that referenced this issue Dec 21, 2018
@vania-pooh
Correctly processing proxy request to avoid abortHandler panic (fixes a…
03d38b8 
…erokube#598)
vania-pooh added a commit that referenced this issue Dec 28, 2018
@vania-pooh
Correctly processing proxy request to avoid abortHandler panic (fixes #…
9513e94 
…598)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.8.4
Development

Successfully merging a pull request may close this issue.

Catching and logging potential panics (e.g. abortHandler) in proxy mo… vania-pooh/selenoid
2 participants
@vania-pooh @potapovDim