Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the appium:deviceName capability to find the specific browser #1305

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

BorisOsipov
Copy link
Contributor

Use the appium:deviceName capability to find the specific browser as well. New Appium clients do not send the non-W3C deviceName capability.

…well. New Appium clients do not send the non-W3C deviceName capability.
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 76.40% // Head: 76.47% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (e3e31bc) compared to base (60bc1a6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
+ Coverage   76.40%   76.47%   +0.06%     
==========================================
  Files          12       12              
  Lines        1437     1441       +4     
==========================================
+ Hits         1098     1102       +4     
  Misses        258      258              
  Partials       81       81              
Flag Coverage Δ
go 76.47% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
session/session.go 93.54% <100.00%> (+0.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vania-pooh vania-pooh merged commit 1176ec6 into aerokube:master Feb 4, 2023
@vania-pooh
Copy link
Member

@BorisOsipov thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants