Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -s3-force-path-style flag #614

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Conversation

nebehr
Copy link
Contributor

@nebehr nebehr commented Nov 28, 2018

Added a flag to force path-style addressing during file upload from Selenoid to S3 (i.e. http://s3.amazonaws.com/BUCKET/KEY instead of http://BUCKET.s3.amazonaws.com/KEY), disabled by default.

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #614 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #614      +/-   ##
==========================================
+ Coverage   78.23%   78.26%   +0.03%     
==========================================
  Files          12       12              
  Lines        1369     1371       +2     
==========================================
+ Hits         1071     1073       +2     
  Misses        228      228              
  Partials       70       70
Flag Coverage Δ
#unittests 78.26% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
upload/s3.go 84.7% <100%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6e4d6...6bf44b6. Read the comment docs.

@vania-pooh vania-pooh merged commit 2e12e14 into aerokube:master Nov 28, 2018
@vania-pooh
Copy link
Member

@nebehr thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants