This repository has been archived by the owner on Mar 16, 2018. It is now read-only.
Prevent IE 11 from using document.selection #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For IE 11, document.selection is no longer supported. See http://msdn.microsoft.com/en-us/library/ie/ms535869(v=vs.85).aspx for details. Updated condition so IE 11 uses selectionStart and selectionEnd.
|
@shanekenney you just saved my day. it would be great to see that merged. |
|
It’s clear I’ve not had the disposition to maintain this repository. @shanekenney, would you be interested in being added as a collaborator to this project? |
|
Very good PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IE 11, document.selection is no longer supported. See
http://msdn.microsoft.com/en-us/library/ie/ms535869(v=vs.85).aspx
for details.
Updated condition so IE 11 uses selectionStart and
selectionEnd similar to Chrome and Firefox.
Versions of IE < 11 are unaffected.