Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directions don't list MobileCoreServices.framework as a requirement #294

Closed
hborders opened this issue Jan 19, 2016 · 5 comments · Fixed by #296
Closed

Directions don't list MobileCoreServices.framework as a requirement #294

hborders opened this issue Jan 19, 2016 · 5 comments · Fixed by #296
Assignees
@radazzouz
Labels
in progress in review

Comments

@hborders
Copy link

I added this project as a submodule and checked out the latest tag (1.7). Then, I added OnePasswordExtension.h, OnePasswordExtension.m and 1Password.xcassets.

When I try to build, I see the following error:

Undefined symbols for architecture x86_64:
  "_kUTTypePropertyList", referenced from:
      -[OnePasswordExtension processExtensionItem:completion:] in OnePasswordExtension.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I worked around this by adding MobileCoreServices.framework to my Link Binary with Libraries build phase. I'm targeting iOS 7.1 and with an iOS 9.2 base SDK.

Please document that MobileCoreServices.framework is a required framework.
@radazzouz radazzouz self-assigned this Jan 19, 2016
@radazzouz
Copy link
Contributor

Hi @hborders,

Thanks for taking the time to write in and for integrating 1Password into your app.

This is already documented in the "Projects supporting iOS 7.1 and earlier" section of the README.

I am therefore closing this issue as invalid. Please let us know if this helps 😉

All the Best!

@hborders
Copy link
Author

The directions list WebKit.framework as a required framework. I was already including that. I see nothing about MobileCoreServices.framework.

@radazzouz
Copy link
Contributor

@hborders, I just changed the deployment target to 7.1 for ACME, our sample app, and I got a compile error about the WebKit.framework, but not about MobileCoreServices.framework. Which version of Xcode are you using?

@radazzouz radazzouz reopened this Jan 19, 2016
@hborders
Copy link
Author

Version 7.2 (7C68)

@radazzouz radazzouz mentioned this issue Jan 19, 2016
Merged
@radazzouz
Copy link
Contributor

Thanks for the quick follow up @hborders 👍

I tested ACME with iOS 7.1 as the Deployment Target and iOS 9.2 (latest) as the Base SDK as seen in this screenshot.

And it all works great! So I submitted PR #296 which should address your documentation issue.

Thanks so much!

radazzouz pushed a commit that referenced this issue Feb 15, 2016
[Release] 1.8
582fa81 
```
[IMPROVED] Improved compatibility with CocoaPods 1.0.0. {#302}
[IMPROVED] Updated the Javascript code for Web View Filling. {#303}
[IMPROVED] Improved the instructions for the Rich Icons submission in the Best Practice section. {#290}
[IMPROVED] Updated the documentation to mention all the required frameworks to link for projects targeting iOS 7.1 or earlier. {#294, #296}
[IMPROVED] Improved the header documentation. {#298}
[IMPROVED] Listing all the required frameworks in the podspec file. {#297}
[IMPROVED] Removed extra new lines for a clearer code and README. {#293}
[IMPROVED] Removed usless semicolons from Swift code. {#295}

[FIXED] Fixed status bar inconsistencies between the Objective-C and the Swift versions of ACME. {#292}
[FIXED] Fixed outdated header comments for the demo apps. {#299}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radazzouz radazzouz

Labels
in progress in review
Projects
None yet
Milestone
No milestone
2 participants
@hborders @radazzouz