Audits extension for nullability #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extension is now audited for nullability, assumes non null for the file as a whole and annotates specific items that are nullable. should improve usage in Swift
|
Thank @tapi! 👍 |
|
Added a nil assertion in one of the methods since the documentation specified that it must be nonnull. |
|
You're still supporting Xcode 5? I can add macro polyfills for the nullability stuff but it should work on Xcode 6 with iOS7 as a deployment target. |
|
Thanks for responding so quickly, @tapi! You're Awesome! I use Xcode 5 to test compatibility with iOS 7.1 and earlier. I also tested with Xcode 6 and it all seems to work fine now. Merging right now! Cheers! |
radazzouz
pushed a commit
that referenced
this pull request
Jun 15, 2015
Audits extension for nullability
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension is now audited for nullability, assumes non null for the file as a whole and annotates specific items that are nullable.
should improve usage in Swift