Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Fixed casting to NSString of CFStringRef constants. #317

Merged
merged 1 commit into from
Mar 30, 2016
Merged

[FIXED] Fixed casting to NSString of CFStringRef constants. #317

merged 1 commit into from
Mar 30, 2016

Conversation

radazzouz
Copy link
Contributor

This should resolve #314. A big 👍 to @hborders!

In ARC we should cast CFStringRefs using (__bridge NSString *). Otherwise, it would generate warning when using the -Wcast-qual compiler flag.

[FIXED] Fixed casting to NSString of CFStringRef constants.
f8863d1 
In ARC we should cast `CFStringRefs` using `(__bridge NSString *)`. Otherwise, it would generate warning when using the `-Wcast-qual` compiler flag.
@radazzouz radazzouz self-assigned this Mar 28, 2016
@radazzouz radazzouz merged commit 917f9e6 into master Mar 30, 2016
@radazzouz radazzouz deleted the fix/cfstringref-casting-in-arc branch March 30, 2016 16:45
radazzouz pushed a commit that referenced this pull request Apr 20, 2016
[Release] 1.8.1
ed3c656 
```
[NEW] Added metadata badges to the README. {#319. #321}

[IMPROVED] Updated the Javascript code for Web View Filling. {#316}

[FIXED] Fixed casting to NSString of CFStringRef constants. {#317}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@radazzouz radazzouz

Labels
done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cast from 'const struct __CFString *' to 'NSString *' drops const qualifier
1 participant
@radazzouz