Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deken test/upload, pd0.55-0, 64bit builds, update pdlibbuilder #47

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

ben-wes
Copy link
Contributor

@ben-wes ben-wes commented Aug 21, 2024

  • version tags (like 0.12.4 will automatically trigger uploads to deken)
  • if the tag contains the string test, the deken packages will still be created and a content list is printed to the workflow summary - but they're not uploaded
  • builds are created for Pd and Pd64 (which was simple after the pdlibbuilder update)
  • the builds are made against pd0.55-0 now

the current v0.12.4 on deken was uploaded by this workflow and is tested on windows (amd64) and macos (arm64 and amd64) with pd and pd64. additional tests on linux might be nice.

deken uploads require the repository secrets DEKEN_USERNAME and DEKEN_PASSWORD

@agraef
Copy link
Owner

agraef commented Aug 22, 2024

Sorry for the dumb question, but can you point me to instructions on how to set up these repository secrets?

@ben-wes
Copy link
Contributor Author

ben-wes commented Aug 22, 2024

Sorry for the dumb question, but can you point me to instructions on how to set up these repository secrets?

i found this, but it's actually a bit outdated:
https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secrets-for-a-repository

so here's an edited screenshot:
Screenshot 2024-08-22 at 07 52 27

@agraef
Copy link
Owner

agraef commented Aug 22, 2024

Ok, I just added these:

image

And entered my puredata.info username and password there. Is that all that's needed?

@ben-wes
Copy link
Contributor Author

ben-wes commented Aug 22, 2024

Ok, I just added these [...] and entered my puredata.info username and password there. Is that all that's needed?

imho, that should be it, yes!

... there might be one little detail to check if it doesn't work: i had some special character in my password a few months ago that obviously wasn't correctly handed over to deken for whatever reason (i don't remember which one it was though).

besides that, you can test all the steps without the upload with a 0.12.4-test tag or so.

and - although i guess that wouldn't be the cleanest way - you could also retag this with 0.12.4 then to get it uploaded through your profile to deken (i would then delete it from mine). but of course, this can also wait until 0.12.5 or so.

@agraef agraef merged commit d3e620e into agraef:master Aug 22, 2024
11 checks passed
@agraef
Copy link
Owner

agraef commented Aug 22, 2024

Ok, the test build went fine, I'll have to recheck this next time I tag a release. Merged, thanks!

@agraef
Copy link
Owner

agraef commented Aug 25, 2024

0.12.5 is out (in which I added a section on signals and graphics to the tutorial), so I had an opportunity to test the Deken upload, and it worked without a hitch! Thanks @ben-wes for the awesome contribution! 👍 🥇

@ben-wes
Copy link
Contributor Author

ben-wes commented Aug 25, 2024

0.12.5 is out (in which I added a section on signals and graphics to the tutorial), so I had an opportunity to test the Deken upload, and it worked without a hitch!

cool! glad to hear that and thanks for the update! ... i saw that one merged artifact slipped into the github release files. i'll slightly change the dependencies there to avoid that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants