Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor workflow simplifications #51

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

ben-wes
Copy link
Contributor

@ben-wes ben-wes commented Aug 27, 2024

since pd-lua is using the actual tag name as version string, there's no need for extracting it from another string.

and the check for a tag is also simpler this way.

tested with https://github.com/ben-wes/pd-lua/actions/runs/10574258362

@agraef agraef merged commit b4197fd into agraef:master Aug 28, 2024
10 checks passed
@agraef
Copy link
Owner

agraef commented Aug 28, 2024

Merged, thanks! I'll test this with a proper release asap. What could possibly go wrong? 😸

@ben-wes
Copy link
Contributor Author

ben-wes commented Aug 28, 2024

Merged, thanks! I'll test this with a proper release asap. What could possibly go wrong? 😸

exactly my thought, haha - just a little PR for the thrill. ;)

(on a more serious note: not planning to mess much with those workflows in the future unless necessary for actual new features)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants