Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more consistent subsequent prerelease versions #154

Merged
merged 16 commits into from
Jun 25, 2024
Merged

fix: more consistent subsequent prerelease versions #154

merged 16 commits into from
Jun 25, 2024

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented Jun 13, 2024

Fixes #106

The only way that I could think of to fix this issue was to take into account the latest prod release for prerelease version bumps.

@stdavis stdavis enabled auto-merge (rebase) June 13, 2024 18:48
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.96%. Comparing base (37a448c) to head (2e1834a).

Files Patch % Lines
src/utils.ts 96.96% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #154       +/-   ##
===========================================
+ Coverage   42.40%   96.96%   +54.56%     
===========================================
  Files           2        1        -1     
  Lines         125       66       -59     
  Branches        0       17       +17     
===========================================
+ Hits           53       64       +11     
+ Misses         72        1       -71     
- Partials        0        1        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdavis stdavis marked this pull request as draft June 13, 2024 19:03
auto-merge was automatically disabled June 13, 2024 19:03

Pull request was converted to draft

@stdavis

This comment was marked as outdated.

@stdavis stdavis marked this pull request as ready for review June 14, 2024 15:44
@stdavis stdavis marked this pull request as draft June 14, 2024 16:13
@stdavis stdavis marked this pull request as ready for review June 14, 2024 16:17
@stdavis
Copy link
Member Author

stdavis commented Jun 14, 2024

@steveoh This is ready for another look.

@stdavis stdavis requested a review from steveoh June 17, 2024 16:38
.gitignore Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting change. It feels sort funky having node modules and build scripts but you gotta do what you gotta do sometimes I suppose.

@stdavis
Copy link
Member Author

stdavis commented Jun 24, 2024

It feels sort funky having node modules and build scripts but you gotta do what you gotta do sometimes I suppose.

I feel the same way but I could not find another way around the bundling issue for loading the angular preset. It is not totally outside of GitHub's recommendations. Their docs suggest it as the first option and then recommend a bundler as an alternative.

@stdavis stdavis merged commit 1be49a9 into main Jun 25, 2024
12 checks passed
@stdavis stdavis deleted the dev branch June 25, 2024 14:24