-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more consistent subsequent prerelease versions #154
Conversation
- eslint v9 upgrade - commonjs -> esm
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
===========================================
+ Coverage 42.40% 96.96% +54.56%
===========================================
Files 2 1 -1
Lines 125 66 -59
Branches 0 17 +17
===========================================
+ Hits 53 64 +11
+ Misses 72 1 -71
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
Pull request was converted to draft
ncc is what GitHub now recommends for building actions. Ref: https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#:~:text=As%20an%20alternative%2C%20you%20can%20use%20a%20tool%20called%20%40vercel/ncc%20to%20compile%20your%20code%20and%20modules%20into%20one%20file%20used%20for%20distribution.
This comment was marked as outdated.
This comment was marked as outdated.
@steveoh This is ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting change. It feels sort funky having node modules and build scripts but you gotta do what you gotta do sometimes I suppose.
I feel the same way but I could not find another way around the bundling issue for loading the angular preset. It is not totally outside of GitHub's recommendations. Their docs suggest it as the first option and then recommend a bundler as an alternative. |
Fixes #106
The only way that I could think of to fix this issue was to take into account the latest prod release for prerelease version bumps.