Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TaskInfo.has_pending_cancellation() false positives on asyncio with shielding #772

Conversation

gschaffner
Copy link
Collaborator

Changes

Fixes #771.

Checklist

If this is a user-facing code change, like a bugfix or a new feature, please ensure that
you've fulfilled the following conditions (where applicable):

  • You've added tests (in tests/) added which would fail without your patch
  • You've updated the documentation (in docs/, in case of behavior changes or new
    features)
  • You've added a new changelog entry (in docs/versionhistory.rst).

Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfection. Thank you!

@agronholm agronholm merged commit f1a46f2 into agronholm:master Aug 29, 2024
17 checks passed
@gschaffner gschaffner deleted the fix-has_pending_cancellation-asyncio-shield branch August 29, 2024 21:59
@gschaffner
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory object streams deadlock on asyncio
2 participants