Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix py.typed path #441

Merged
merged 1 commit into from
Apr 25, 2020
Merged

fix py.typed path #441

merged 1 commit into from
Apr 25, 2020

Conversation

kentac55
Copy link
Contributor

ulid-py has py.typed but not included in built package because of invalid package_data path in setup.py.

It cause mypy error.

import ulid

print(ulid.new())
ulid_sample/a.py:1: error: Skipping analyzing 'ulid': found module but no type hints or library stubs

before:

$ python setup.py build
Warning: 'classifiers' should be a list, got type 'tuple'
running build
running build_py
creating build
creating build/lib
creating build/lib/ulid
copying ulid/__init__.py -> build/lib/ulid
copying ulid/api.py -> build/lib/ulid
copying ulid/base32.py -> build/lib/ulid
copying ulid/hints.py -> build/lib/ulid
copying ulid/ulid.py -> build/lib/ulid

after:

$ python setup.py build
Warning: 'classifiers' should be a list, got type 'tuple'
running build
running build_py
creating build
creating build/lib
creating build/lib/ulid
copying ulid/__init__.py -> build/lib/ulid
copying ulid/api.py -> build/lib/ulid
copying ulid/base32.py -> build/lib/ulid
copying ulid/hints.py -> build/lib/ulid
copying ulid/ulid.py -> build/lib/ulid
copying ulid/py.typed -> build/lib/ulid

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #441   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          312       312           
  Branches        75        75           
=========================================
  Hits           312       312           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c78be2...7830ba4. Read the comment docs.

@ahawker
Copy link
Owner

ahawker commented Apr 25, 2020

Build passed (https://travis-ci.org/github/ahawker/ulid/builds/674778087) but status check isn't updated.

@kentac55 Thanks for the fix!

Travis CI enables your team to test and ship your apps with confidence. Easily sync your projects with Travis CI and you'll be testing your code in minutes.

@ahawker ahawker closed this Apr 25, 2020
@ahawker ahawker reopened this Apr 25, 2020
@ahawker ahawker merged commit 8fd65ff into ahawker:master Apr 25, 2020
@ahawker
Copy link
Owner

ahawker commented Apr 25, 2020

This will be available in the 0.0.14 release

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants