Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mypy strict #453

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Support mypy strict #453

merged 2 commits into from
Jun 17, 2020

Conversation

ahawker
Copy link
Owner

@ahawker ahawker commented Jun 17, 2020

Status: Ready

If merged, this PR makes the changes necessary to support mypy --strict and updates the Makefile target to run in strict mode as part of CI.

Fixes #450

Repository owner deleted a comment from houndci-bot Jun 17, 2020
Repository owner deleted a comment from houndci-bot Jun 17, 2020
Repository owner deleted a comment from houndci-bot Jun 17, 2020
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #453 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #453   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          312       316    +4     
  Branches        75        75           
=========================================
+ Hits           312       316    +4     
Impacted Files Coverage Δ
ulid/hints.py 100.00% <100.00%> (ø)
ulid/ulid.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c41005...751a857. Read the comment docs.

@ahawker ahawker merged commit 751a857 into master Jun 17, 2020
@personal-probot personal-probot bot deleted the feature/mypy-strict branch June 17, 2020 15:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with using ulid with mypy --strict
1 participant