use tinybench for benchmarking #485
Conversation
| ) | ||
| }) | ||
|
|
||
| bench.threshold = 10 |
There was a problem hiding this comment.
What is the reason behind these changes?
There was a problem hiding this comment.
lesser execution time. Threshold could be increased to a number of benchmark tasks (bench._tasks.size) which is even faster, but 10 is recommended by tinybench docs
There was a problem hiding this comment.
Can you explain why, can’t understand by docs what is default and what exactly we will change here? CI is almost identical.
There was a problem hiding this comment.
By default, benchmark tasks run synchronously. On nanoid benchmark suite the concurrent run not saving much time (it's -1 second for me: 21sec for synchronous run and 20 for concurrent).
So, using concurrent warmup and run for benchmark is not something of a real need, since it gives about 4% better execution time
There was a problem hiding this comment.
Let’s close it since I'm afraid of some benchmark result issues with concurrent
No description provided.