Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with WEAS viewer. #559

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yakutovicha
Copy link
Member

@yakutovicha yakutovicha commented Feb 23, 2024

Requires superstar54/weas-widget#22.

Here is the way to test it:

  1. Enter AiiDAlab's terminal, cd into the ~/apps/ folder
  2. Clone the awb repository, and enter it: cd aiidalab-widgets-base
  3. Switch to the feature/weas-viewer-integration branch
  4. Pip install it: pip install --user -e .
  5. Go to another location and git clone my fork of the weas-widget.
  6. Enter the folder and switch to the feature/integrate-with-structuremanager-widget branch.
  7. Pip install it: pip install --user -e .
  8. Open File Manager in AiiDAlab and enter the apps/aiidalab-widgets-base/notebooks folder
  9. Launch structures.ipynb and execute its cells.

Problems:

  1. When integrated with awb's StructureManager the control icons look weird:
    image

  2. When uploading a new structure with the StructureManager, the weas viewer doesn't show it. The only way for it to work is to launch a viewer in a separate cell and execute it:

image

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.50%. Comparing base (8808a3c) to head (1340e40).
Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   87.07%   87.50%   +0.42%     
==========================================
  Files          27       27              
  Lines        4649     5321     +672     
==========================================
+ Hits         4048     4656     +608     
- Misses        601      665      +64     
Flag Coverage Δ
python-3.10 87.50% <100.00%> (+0.42%) ⬆️
python-3.9 87.53% <100.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54
Copy link
Member

Hi @yakutovicha ,

When integrated with awb's StructureManager the control icons look weird:

this is fixed. Also the undo and redo buttons hidden using the guiConfig parameter.

Besides, the text of the dropdown in the control was wrong; this has also been fixed.

When uploading a new structure with the StructureManager, the weas viewer doesn't show it.

This is also fixed.

Please test it again, and see is there any update required from the weas side.

@superstar54
Copy link
Member

Enter the folder and switch to the feature/integrate-with-structuremanager-widget branch.
Pip install it: pip install --user -e .

now it also needs to run npm to install weas-widget locally

npm install
npm run build
pip install -e .

@danielhollas danielhollas added the enhancement New feature or request label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants