-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PythonJob
supports list of AiiDA node as output
#190
Open
superstar54
wants to merge
8
commits into
main
Choose a base branch
from
add_namespace_list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+103
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 75.75% 75.71% -0.04%
==========================================
Files 70 69 -1
Lines 4615 4732 +117
==========================================
+ Hits 3496 3583 +87
- Misses 1119 1149 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Parse list output, give a special name as key, `list_data_{i}` - When prepre the submission, if the key of a dict item start with `list_data_`, we assume that this should convert to a list.
NamespaceList
PythonJob
supports list of AiiDA data as output
PythonJob
supports list of AiiDA data as outputPythonJob
supports list of AiiDA node as output
Change the list to dict, with the key as `list_data_{i}`.
This is useful in the test.
0556752
to
3b3487c
Compare
ece97b9
to
98bc7da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be very helpful (user-friendly) for
PythonJob
to support a list of AiiDA nodes as the output. In order to do that:list_data_{i}
list_data_
, we assume that this should convert to a list.Note that this will be handled internally by the
PythonJob
, so the user will not be aware of this.Use the example of EOS from @mbercx ,